[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 24 14:15:00 PDT 2020
asbirlea added a comment.
Yes. The difference in perf in instructions and cycles count is due to reversing the update order.
I'm still not seeing meaningful changes in wall-time even with the update order reversed, but reliable wall-time testing is hard.
I do have changes that
- drop the GraphTraits usage entirely in favor of the getChildren() method in GraphDiff
- refactor the hashmaps in GraphDiff
but I plan to send those separately.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77341/new/
https://reviews.llvm.org/D77341
More information about the llvm-commits
mailing list