[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D77341#2171305 <https://reviews.llvm.org/D77341#2171305>, @asbirlea wrote:

> The increase in number of instructions and cycles was caused by reversing the order in which the updates are applied by GraphDiff.
>  I'll look into re-adding some of the original cleanups in a follow-up patch.


Fascinating - and you were able to reproduce this by just reversing the order in the old code (using ChildrenGetter/building a vector and returning it - not using all the iterator adapters, etc) and that the performance problem was no longer present in the new code if you changed its order to match?

Huh. (again, sorry this has been such a slog :/)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77341/new/

https://reviews.llvm.org/D77341