[PATCH] D83588: [TableGen][CGS] Print better errors on overlapping InstRW

[Evandro Menezes via Phabricator via llvm-commits]

evandro accepted this revision.
evandro added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/TableGen/Error.cpp:53
+  std::exit(1);
+}
+
----------------
jroelofs wrote:
> evandro wrote:
> > Please, do not make it fatal.
> This is appropriate for places that replace an existing `PrintFatalError();` with a `PrintError(); PrintFatalNote();` sequence.
> 
> If you'd like to take on replacing cases of `PrintFatalError()` with `PrintError()`, I'd be happy to review your patch.
Fair enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83588/new/

https://reviews.llvm.org/D83588