[PATCH] D83588: [TableGen][CGS] Print better errors on overlapping InstRW

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 16:28:44 PDT 2020


jroelofs marked 2 inline comments as done.
jroelofs added inline comments.


================
Comment at: llvm/lib/TableGen/Error.cpp:53
+  std::exit(1);
+}
+
----------------
evandro wrote:
> Please, do not make it fatal.
This is appropriate for places that replace an existing `PrintFatalError();` with a `PrintError(); PrintFatalNote();` sequence.

If you'd like to take on replacing cases of `PrintFatalError()` with `PrintError()`, I'd be happy to review your patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83588/new/

https://reviews.llvm.org/D83588





More information about the llvm-commits mailing list