[PATCH] D83834: Add test utility 'extract'

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D83834#2172461 <https://reviews.llvm.org/D83834#2172461>, @lattner wrote:

> I don't see any reason to prefer a short name here, this isn't a simple too like 'opt' it takes command line flags etc.


generally agreed the name could be more specific, with or without an llvm prefix

> Unrelatedly, I don't agree with your rationale for having a separate tool.  You're right that moving files to an Inputs directory moves them further away, but that isn't what I was suggesting.  Also, there is great precedent across the testsuite for this, and the proposed tool isn't a general solution to the problem (e.g. binary files etc).

Hmm - what precedent are you referring to here - any particular examples you could point me to? Because my understanding is that Google's internal test runner actually relies on input files being in the Input directory, so I don't think we have cases where other input files are specified via substitutions like %s.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834