[PATCH] D83834: Add test utility 'extract'

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D83834#2172461 <https://reviews.llvm.org/D83834#2172461>, @lattner wrote:

> I don't see any reason to prefer a short name here, this isn't a simple too like 'opt' it takes command line flags etc.


not, count, FileCheck, `update_*_test_checks.py`. These utilities set a precedent that these auxiliary test-only utilities are not named `llvm-*`.

> Unrelatedly, I don't agree with your rationale for having a separate tool.  You're right that moving files to an Inputs directory moves them further away, but that isn't what I was suggesting.  Also, there is great precedent across the testsuite for this, and the proposed tool isn't a general solution to the problem (e.g. binary files etc).

I acknowledge that this falls into subjective points of view and people may have different opinions. For me, non-trivial separate files (not creatable with one-line echo) have caused enough pain to me. It is not unusual for me open two or three auxiliary files in Inputs/ to understand the purpose of a test. If I don't count wrong, at least @grimar, @jhenderson and @probinson hold a similar viewpoint.

(For binary files, they are sometimes useful, e.g. when testing compatibility of LLVM IR. a llvm/test/Bitcode/ pre-built file ensures that compatibility is retained. However, their use cases are very narrow. In 99% cases textual formats will be a superior replacement. I hope we don't let 1% inapplicable use case to be the reason that a general purpose testing utility should not be introduced. )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834