[PATCH] D82927: Intergerate Loop Peeling into Loop Fusion

Bardia Mahjour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 09:24:46 PDT 2020


bmahjour added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:804
+        }
+        // Cannot modify the Predecessors inside the above loop as it will cause
+        // the iterators to be nullptrs, causing memory errors.
----------------
Predecessors  -> predecessors


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:806
+        // the iterators to be nullptrs, causing memory errors.
+        for (unsigned i = 0; i < WorkList.size(); i++) {
+          Instruction *CurrentBranch = WorkList[i];
----------------
Please use range-based for loops whenever possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82927/new/

https://reviews.llvm.org/D82927





More information about the llvm-commits mailing list