[PATCH] D82927: Intergerate Loop Peeling into Loop Fusion

Sidharth Baveja via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 05:52:35 PDT 2020


sidbav marked 12 inline comments as done.
sidbav added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:1347
     // Then modify the control flow and update DT and PDT.
-    SmallVector<DominatorTree::UpdateType, 8> TreeUpdates;
+    SmallVector<DominatorTree::UpdateType, 16> TreeUpdates;
 
----------------
MaskRay wrote:
> Rationale for an increase? Large inline count can consume more stack space.
Initially was planning to have the logic from lines 795-805 in this block, which is why I increased from 8 -> 16, but I forgot to change it back.  


================
Comment at: llvm/test/Transforms/LoopFusion/guarded_unsafeblock_peel.ll:1
+; RUN: opt -S -loop-fusion -loop-fusion-peel-max-count=3 < %s | FileCheck %s
+
----------------
MaskRay wrote:
> `file-name.ll` is more common than `file_name.ll`
The Loop Fusion lit tests follow the `file_name.ll` convention, so I will keep the files names like this. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82927/new/

https://reviews.llvm.org/D82927





More information about the llvm-commits mailing list