[PATCH] D84386: [DWARFYAML] Add support for emitting custom operands for range list entry.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 02:30:05 PDT 2020


Higuoxing marked an inline comment as done.
Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:531
+
+  switch ((uint8_t)Entry.Operator) {
   case dwarf::DW_RLE_end_of_list:
----------------
grimar wrote:
> Do you need a cast here?
I'm not sure about it here. Seems that some build bots are not happy if we do not add a cast here since we have covered all enumeration values in this switch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84386/new/

https://reviews.llvm.org/D84386





More information about the llvm-commits mailing list