[PATCH] D84386: [DWARFYAML] Add support for emitting custom operands for range list entry.

Thu Jul 23 02:26:40 PDT 2020

labath added a comment.

In D84386#2168813 <https://reviews.llvm.org/D84386#2168813>, @jhenderson wrote:

> In general terms, I think this is a good solution. Let's see what @grimar and @labath think.

Pretty much what I said already. This might be a nice way to test parsing of unknown/invalid DW_LLE constants, but there's only so many of those kinds of tests that we need, so it seems unnecessary.

Furthermore, once we're down in the invalid input land, it becomes very important to know how the bytes are laid out exactly in order to understand what the parser will do/has done. This becomes a (small) obstacle in that because I have to reason about the actual byte sequence that will be produced by this yaml -- I would prefer if I just had the bytes directly.

But if you do want to have this, I'm not going to stop you...

================
Comment at: llvm/include/llvm/ObjectYAML/DWARFYAML.h:439-445
+    io.enumCase(value, "Unsigned8",
+                DWARFYAML::ListEntryOperandTypes::Unsigned8);
+    io.enumCase(value, "Unsigned16",
+                DWARFYAML::ListEntryOperandTypes::Unsigned16);
+    io.enumCase(value, "Unsigned32",
+                DWARFYAML::ListEntryOperandTypes::Unsigned32);
+    io.enumCase(value, "Unsigned64",
----------------
jhenderson wrote:
> It might be nice to call these `U8`, `U16` etc, to make them nice and concise.
+1

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84386/new/

https://reviews.llvm.org/D84386