[PATCH] D84347: [MLIR,OpenMP] Lowering of parallel operation: proc_bind clause 2/n

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:92
 
+ProcBindKind getProcBindKind(llvm::StringRef Str);
+
----------------
Documentation please.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPConstants.cpp:29
+
+} // end namespace llvm
----------------
We had a file like this before, I think. We removed it because the content was generated. Maybe this is the time to move the proc bind enum to tablegen?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84347/new/

https://reviews.llvm.org/D84347