[PATCH] D82995: [UpdateTestChecks] Allow $ in function names
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 22 19:13:03 PDT 2020
jdoerfert added a comment.
In D82995#2167526 <https://reviews.llvm.org/D82995#2167526>, @greened wrote:
> In D82995#2137715 <https://reviews.llvm.org/D82995#2137715>, @jdoerfert wrote:
>
> > We need a test.
> >
> > If it helps, OpenMP begin/end declare variant mangles the names with `$`, so do we for CUDA (sometimes).
>
>
> Thanks. Where should tests go? I don't think they should go in clang's `test/utils/update_cc_test_checks` as this isn't just testing that tool. This adds capability to `update_test_checks.py` and `update_llc_test_checks.py` too.
My bad, `llvm/test/tools/UpdateTestChecks` is the test folder for these things.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82995/new/
https://reviews.llvm.org/D82995
More information about the llvm-commits
mailing list