[PATCH] D82995: [UpdateTestChecks] Allow $ in function names

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 11:29:13 PDT 2020


greened added a comment.

In D82995#2137715 <https://reviews.llvm.org/D82995#2137715>, @jdoerfert wrote:

> We need a test.
>
> If it helps, OpenMP begin/end declare variant mangles the names with `$`, so do we for CUDA (sometimes).


Thanks.  Where should tests go?  I don't think they should go in clang's `test/utils/update_cc_test_checks` as this isn't just testing that tool.  This adds capability to `update_test_checks.py` and `update_llc_test_checks.py` too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82995/new/

https://reviews.llvm.org/D82995





More information about the llvm-commits mailing list