[PATCH] D84261: [PGO] Supporting code for always instrumenting entry block

[Rong Xu via Phabricator via llvm-commits]

xur marked 2 inline comments as done.
xur added inline comments.


================
Comment at: clang/test/CodeGenCXX/Inputs/profile-remap.proftext:3
+:entry_first
 _ZN3Foo8functionENS_1XE
 29667547796
----------------
davidxl wrote:
> is this change needed?
They are not needed. 

This actually tests the new proftext file.

We can remove it and the change in gcc-flag-compatibility_IR.proftext
Or add update the test to use the new proftext.


================
Comment at: llvm/lib/ProfileData/InstrProfReader.cpp:184
+    return error(instrprof_error::bad_header);
+  ++Line;
   return success();
----------------
davidxl wrote:
> The parser should probably be made such that  the order of the directive does not matter.
That can be done.


How about duplicates? if the order does not matter, I assume we can have multiple directive and the last one rules?
Or we need to throw an error when seeing duplicates?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84261/new/

https://reviews.llvm.org/D84261