[PATCH] D84261: [PGO] Supporting code for always instrumenting entry block

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: clang/test/CodeGenCXX/Inputs/profile-remap.proftext:3
+:entry_first
 _ZN3Foo8functionENS_1XE
 29667547796
----------------
is this change needed?


================
Comment at: llvm/lib/ProfileData/InstrProfReader.cpp:184
+    return error(instrprof_error::bad_header);
+  ++Line;
   return success();
----------------
The parser should probably be made such that  the order of the directive does not matter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84261/new/

https://reviews.llvm.org/D84261