[PATCH] D84199: GlobalISel: Add utilty for getting function argument live ins

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 02:03:59 PDT 2020


hsmhsm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:4713
       // clobbered by anything.
-      MachineBasicBlock &EntryBlock = *MF.begin();
-      if (!EntryBlock.isLiveIn(AArch64::LR))
-        EntryBlock.addLiveIn(AArch64::LR);
-      MachineIRBuilder EntryBuilder(MF);
-      EntryBuilder.setInstr(*EntryBlock.begin());
-      EntryBuilder.buildCopy({DstReg}, {Register(AArch64::LR)});
+      Register LiveInLR = getFunctionLiveInPhysReg(MF, TII, AArch64::LR,
+                                                   AArch64::GPR64spRegClass);
----------------
Is not it, the function name supposed to be - `getFunctionLiveInVirtualReg`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84199/new/

https://reviews.llvm.org/D84199





More information about the llvm-commits mailing list