[PATCH] D84199: GlobalISel: Add utilty for getting function argument live ins

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:524
+
+  BuildMI(EntryMBB, EntryMBB.begin(), DL, TII.get(TargetOpcode::COPY), LiveIn)
+    .addReg(PhysReg);
----------------
paquette wrote:
> Why not `MachineIRBuilder`?
I think single use MachineIRBuilders are a bad idea since they maintain observers and CSEinfo etc. I could have it pass in one, but then it would have to change the insert block / insert point and restore it which is more complicated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84199/new/

https://reviews.llvm.org/D84199