[PATCH] D84206: [llvm-libtool-darwin] Add support for -filelist option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:61
+
+  line_iterator I(Ref, /*SkipBlanks=*/false), E;
+  if (I == E)
----------------
line_iterator supports `is_at_eof`. You can delete `E`


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:187
+    WithColor::defaultErrorHandler(std::move(E));
+    exit(EXIT_FAILURE);
+  }
----------------
Prefer return to exit in `main`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84206/new/

https://reviews.llvm.org/D84206