[PATCH] D84206: [llvm-libtool-darwin] Add support for -filelist option

Sameer Arora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 10:38:58 PDT 2020


sameerarora101 marked an inline comment as done.
sameerarora101 added inline comments.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:69-70
+    if (Line.empty())
+      return createStringError(std::errc::invalid_argument,
+                               "'': No such file or directory");
+
----------------
I was getting an assertion error that filenames can't be empty. Hence, now I am explicitly throwing the error here only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84206/new/

https://reviews.llvm.org/D84206





More information about the llvm-commits mailing list