[PATCH] D84194: [AMDGPU] Correct the number of SGPR blocks used for GFX9

Tue Jul 21 14:47:15 PDT 2020

scott.linder added a comment.

In D84194#2164406 <https://reviews.llvm.org/D84194#2164406>, @rochauha wrote:

> In D84194#2164227 <https://reviews.llvm.org/D84194#2164227>, @arsenm wrote:
>
> > Needs test
>
>
> I think these changes are tested using the test in https://reviews.llvm.org/D80713.
>  In fact the issue was found when testing round tripping for the above patch. I guess this can only be verified by a round trip test when we assemble->disassemble->re-assemble? Such a test is already present in the patch for D80713 <https://reviews.llvm.org/D80713>.
>
> I am not sure how else can we look at the value of `GRANULATED_WAVEFRONT_SGPR_COUNT` in a test case.

I think you should be able to test this by adding another KD case to `llvm/test/MC/AMDGPU/hsa-v3.s`, and just checking the hexdump of the KD as for the other cases there. It should be pretty painless, you can just copy-paste the minimal one, set the SGPR count to trigger the bug, and update the `GRANULATED_WAVEFRONT_SGPR_COUNT` bits in the expected dump.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84194/new/

https://reviews.llvm.org/D84194