[PATCH] D84194: [AMDGPU] Correct the number of SGPR blocks used for GFX9

Ronak Chauhan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 08:40:01 PDT 2020


rochauha added a comment.

In D84194#2164227 <https://reviews.llvm.org/D84194#2164227>, @arsenm wrote:

> Needs test


I think these changes are tested using the test in https://reviews.llvm.org/D80713.
In fact the issue was found when testing round tripping for the above patch. I guess this can only be verified a round trip test when we assemble->disassemble->re-assemble? Such a test is already present in the patch for D80713 <https://reviews.llvm.org/D80713>.

I am not sure how else can we look at the value of `GRANULATED_WAVEFRONT_SGPR_COUNT` in a test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84194/new/

https://reviews.llvm.org/D84194





More information about the llvm-commits mailing list