[PATCH] D84219: [gn build] mac: use frameworks instead of libs where appropriate

[Mark Mentovai via Phabricator via llvm-commits]

markmentovai added a comment.

In D84219#2164423 <https://reviews.llvm.org/D84219#2164423>, @thakis wrote:

> Thanks for the patch!
>
> This will break the build with old GNs, right? Should we make this dependent on `gn_version` to keep both versions working for a while? (As-is, it'll break my mac bot.)


It’d have to be a six-month-old GN or older, which seems like a long enough window. GN has had support for “frameworks” since https://gn.googlesource.com/gn/+/a09ec16183b550073c04fa8eeee230047835d118, 2020-01-16.

If you think you need a wider window than that for the LLVM GN build, I’ll accommodate with a gn_version check (and, note to self, the magic number is ≥ 1693). But if your bot’s GN has been upgraded in the past six months and you agree that six months is longer than how recent we’d expect people’s GNs to be, the gn_version check shouldn’t be necessary.

If you just want a better message than a mysterious failure to help users out, maybe we could carry this for a little while?

  assert(gn_version >= 1693, "Update GN, perhaps by running llvm/utils/gn/get.py")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84219/new/

https://reviews.llvm.org/D84219