[PATCH] D82927: Intergerate Loop Peeling into Loop Fusion

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 12:31:04 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/Transforms/LoopFusion/guarded_unsafeblock_peel.ll:1
+; RUN: opt -S -loop-fusion -loop-fusion-peel-max-count=3 < %s | FileCheck %s
+
----------------
`file-name.ll` is more common than `file_name.ll`


================
Comment at: llvm/test/Transforms/LoopFusion/guarded_unsafeblock_peel.ll:10
+; CHECK: void @unsafe_exitblock
+; CHECK: for.first.guard
+; CHECK: br i1 %cmp3, label %for.first.preheader, label %for.second.guard
----------------
Add some spaces after `; CHECK:` so that they align with `; CHECK-NEXT: `
I usually indent instructions more than labels.

```
; CHECK:      for.first.preheader:
; CHECK-NEXT:   br label %for.first
```


================
Comment at: llvm/test/Transforms/LoopFusion/peel.ll:3
+
+; This will test whether we can fuse two loops together if they have constant
+; but a different tripcount.
----------------
`This tests` or just `Test`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82927/new/

https://reviews.llvm.org/D82927





More information about the llvm-commits mailing list