[PATCH] D82927: Intergerate Loop Peeling into Loop Fusion

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I am sorry but I reverted this in 8a268bec1b02dd446fbc36e20d0a9af45d764f67 <https://reviews.llvm.org/rG8a268bec1b02dd446fbc36e20d0a9af45d764f67>.

3 check-llvm-transforms-loopfusion tests in an ASAN build.

BTW, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script:

  arcfilter () {
          arc amend
          git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
  }

`Reviewed By: ` is considered important by some people. Please keep the tag. (`--date=now` is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))

`llvm/utils/git/pre-push.py` can validate the message does not include unneeded tags. Please clean up tags for future commits (`arc land` does not seem to work). Thanks.



================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:796
+      SmallVector<DominatorTree::UpdateType, 8> TreeUpdates;
+      for (BasicBlock *Pred : predecessors(BB)) {
+        if (Pred != FC0.ExitBlock) {
----------------
This line may operate on a deleted BB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82927/new/

https://reviews.llvm.org/D82927