[PATCH] D84243: Build: Move TF source file inclusion from build system to source files

[Nico Weber via Phabricator via llvm-commits]

thakis marked 2 inline comments as done.
thakis added a comment.

Thanks!



================
Comment at: llvm/include/llvm/Config/config.h.cmake:350
 
+/* Define if LLVM was built with a dependency to the tensorflow compiler */
+#cmakedefine LLVM_HAVE_TF_AOT
----------------
mtrofin wrote:
> There's already a LLVM_HAVE_TF_API in llvm-config.h.cmake. Should LLVM_HAVE_TF_AOT move there, too?
> 
> (or vice-versa - it wasn't too clear to me which file is for what)
config.h is for llvm-internal things. looks like this one doesn't have to be exposed to users of llvm.


================
Comment at: llvm/lib/Analysis/CMakeLists.txt:80
   LoopPass.cpp
+  LoopUnrollAnalyzer.cpp
+  MLInlineAdvisor.cpp
----------------
mtrofin wrote:
> nit: why did LoopUnrollAnalyzer move? if it's a drive-by change (to keep sorting), should LoopNestAnalysis.cpp also move?
I ran `:sort` to put the ML files in the right place. This was an unintentional change, I'll move it back.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84243/new/

https://reviews.llvm.org/D84243