[PATCH] D84243: Build: Move TF source file inclusion from build system to source files

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin accepted this revision.
mtrofin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Config/config.h.cmake:350
 
+/* Define if LLVM was built with a dependency to the tensorflow compiler */
+#cmakedefine LLVM_HAVE_TF_AOT
----------------
There's already a LLVM_HAVE_TF_API in llvm-config.h.cmake. Should LLVM_HAVE_TF_AOT move there, too?

(or vice-versa - it wasn't too clear to me which file is for what)


================
Comment at: llvm/lib/Analysis/CMakeLists.txt:80
   LoopPass.cpp
+  LoopUnrollAnalyzer.cpp
+  MLInlineAdvisor.cpp
----------------
nit: why did LoopUnrollAnalyzer move? if it's a drive-by change (to keep sorting), should LoopNestAnalysis.cpp also move?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84243/new/

https://reviews.llvm.org/D84243