[PATCH] D84099: [llvm-reduce] Fix incorrect indices in argument reduction pass

Tue Jul 21 01:05:02 PDT 2020

arichardson marked 2 inline comments as done.
arichardson added inline comments.

================
Comment at: llvm/test/Reduce/remove-args-2.ll:4-5
+;
+; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-args.py %s -o %t
+; RUN: cat %t | FileCheck -implicit-check-not=uninteresting %s
+
----------------
lebedev.ri wrote:
> arichardson wrote:
> > dblaikie wrote:
> > > Sorry I've only been watching this work superficially - but it looked like some other patches were moving towards using FileCheck directly (as the test program) for new llvm-reduce tests? Could that be done here too?
> > Yeah that would definitely work. I didn't do it here since the test I used as a baseline didn't and I was able to reuse the same script.
> > 
> > I can commit a follow-up change to use Filecheck for this test unless @lebedev.ri already has a change to clean up the existing tests.
> > I can commit a follow-up change to use Filecheck for this test 
> 
> Please feel free to. See latest tests i've added for examples.
Fixed in rGf5d4a58b4a2621674de97ea3f796687eb0810c7f

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84099/new/

https://reviews.llvm.org/D84099