[PATCH] D84099: [llvm-reduce] Fix incorrect indices in argument reduction pass

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/test/Reduce/remove-args-2.ll:4-5
+;
+; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-args.py %s -o %t
+; RUN: cat %t | FileCheck -implicit-check-not=uninteresting %s
+
----------------
arichardson wrote:
> dblaikie wrote:
> > Sorry I've only been watching this work superficially - but it looked like some other patches were moving towards using FileCheck directly (as the test program) for new llvm-reduce tests? Could that be done here too?
> Yeah that would definitely work. I didn't do it here since the test I used as a baseline didn't and I was able to reuse the same script.
> 
> I can commit a follow-up change to use Filecheck for this test unless @lebedev.ri already has a change to clean up the existing tests.
> I can commit a follow-up change to use Filecheck for this test 

Please feel free to. See latest tests i've added for examples.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84099/new/

https://reviews.llvm.org/D84099