[PATCH] D80750: llvm-link: Add module flag behavior MergeTargetID

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

> Except for the id string, all feature strings end with '+' or '-'.

Except for the triple string you mean?

What is the difference to the `"target-features"` attribute we have? Shouldn't we use the same encoding instead of inventing yet another one?



================
Comment at: llvm/docs/LangRef.rst:6493
+           is in both source and destination target ID's but with different
+           signs, an error of conflict module flags will be emitted.
+
----------------
This sounds an awful lot like mismatches in regular target triples. Do we really need a new mechanism and wording here, and if so, couldn't we restrict it to the features? I mean, there is a target triple already in the module, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80750/new/

https://reviews.llvm.org/D80750