[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:313
+  static constexpr uint32_t HasControlledStorageMask = 0x0000'0800;
+  static constexpr uint32_t IsTOCLessMask = 0x0000'0400;
+  static constexpr uint32_t IsFloatPointPresentMask = 0x0000'0200;
----------------
The "less" is part of a compound adjective and is not a separate word:
s/IsTOCLessMask/IsTOClessMask/;


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:314
+  static constexpr uint32_t IsTOCLessMask = 0x0000'0400;
+  static constexpr uint32_t IsFloatPointPresentMask = 0x0000'0200;
+  static constexpr uint32_t IsLogOrAbortFloatPointOperationMask = 0x0000'0100;
----------------
Here and below: I don't see an advantage to saving three characters by using "FloatPoint" instead of "FloatingPoint".


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:315
+  static constexpr uint32_t IsFloatPointPresentMask = 0x0000'0200;
+  static constexpr uint32_t IsLogOrAbortFloatPointOperationMask = 0x0000'0100;
+
----------------
The name should be `IsFloatingPointOperationLogOrAbortEnabledMask`.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:321
+  static constexpr uint32_t IsAllocaUsedMask = 0x0000'0020;
+  static constexpr uint32_t IsOnConditionDirectiveMask = 0x0000'001C;
+  static constexpr uint32_t IsCRSavedMask = 0x0000'0002;
----------------
This is not a boolean value. Please fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585