[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 17 13:58:02 PDT 2020
jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.
LGTM with minor nit.
================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:411
+
+ /// Parse a XCOFF Traceback Table from \a Ptr with \a Size bytes.
+ /// Returns a XCOFFTracebackTable upon successful parsing, otherwise an Error
----------------
nit:
XCOFF pronounces "ex", so it should be `an` XCOFF.
The same for `Returns an XCOFF...` below.
Sorry for the churn.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81585/new/
https://reviews.llvm.org/D81585
More information about the llvm-commits
mailing list