[PATCH] D83958: [DebugInfo] Fix a misleading usage of DWARF forms with DIEExpr. NFC.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 19:51:56 PDT 2020


ikudrin added a comment.

The change is NFC (NFCI?). The form is ignored in `DIEExpr::emitValue()` and only the result of `SizeOf()` is used, which returned the expected value because it used `AP->getPointerSize()` for unhandled forms. All the construction is quite fragile and worked only thanks to the fortune.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83958/new/

https://reviews.llvm.org/D83958





More information about the llvm-commits mailing list