[PATCH] D83958: [DebugInfo] Fix a misleading usage of DWARF forms with DIEExpr. NFC.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

I guess this change is NFC? The observable behavior (the exact bits) produced by LLVM remains the same - because, even though the form changed, blocks don't actually have forms, it's just a way for us to internally communicate how things should be encoded?

(I guess if we had a really big TLS symbol location then the ULEB encoding would be a problem? Hmm - actually, if sizeof() does the right thing, but the code that actually wrote the value wrote it out as ULEB, wouldn't that throw off the whole encoding & not write enough bytes to the block? That sounds like it'd be testable in some form? (later ops wouldn't be at the right byte offset, or the whole DWARF emission would be a bit short & throw off everything?))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83958/new/

https://reviews.llvm.org/D83958