[PATCH] D83570: [Matrix] Lowering pass should also run at O0

Sjoerd Meijer via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 07:27:34 PDT 2020


Cool, done in  rG3a624c327add<https://reviews.llvm.org/rG3a624c327adde62d075a4477e9bb9e6a2c186731>.
________________________________
From: Florian Hahn <florian_hahn at apple.com>
Sent: 16 July 2020 13:27
To: reviews+D83570+public+81ea3bf8c3fc81d9 at reviews.llvm.org <reviews+D83570+public+81ea3bf8c3fc81d9 at reviews.llvm.org>
Cc: Sjoerd Meijer <Sjoerd.Meijer at arm.com>; llvm-commits <llvm-commits at lists.llvm.org>
Subject: Re: [PATCH] D83570: [Matrix] Lowering pass should also run at O0



> On Jul 16, 2020, at 12:18, Sjoerd Meijer via Phabricator <reviews at reviews.llvm.org> wrote:
>
> SjoerdMeijer added a comment.
>
> In D83570#2155389 <https://reviews.llvm.org/D83570#2155389>, @fhahn wrote:
>
>> In D83570#2144734 <https://reviews.llvm.org/D83570#2144734>, @SjoerdMeijer wrote:
>>
>>> Ah okay, cheers, missed that. Time to abandon this.
>>
>>
>> I just committed a similar fix upstream, because there are some bots building the test-suite with -O0, to unblock them. The proper fix (run in lightweight lowering in the backend) will need a bit more time unfortunately.
>
>
> Cheers.
> And I will commit the test of this patch then as that still seems useful to me.
>


Sounds good to me, thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200716/14bbb9b8/attachment.html>


More information about the llvm-commits mailing list