[PATCH] D83570: [Matrix] Lowering pass should also run at O0

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 05:27:56 PDT 2020



> On Jul 16, 2020, at 12:18, Sjoerd Meijer via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> SjoerdMeijer added a comment.
> 
> In D83570#2155389 <https://reviews.llvm.org/D83570#2155389>, @fhahn wrote:
> 
>> In D83570#2144734 <https://reviews.llvm.org/D83570#2144734>, @SjoerdMeijer wrote:
>> 
>>> Ah okay, cheers, missed that. Time to abandon this.
>> 
>> 
>> I just committed a similar fix upstream, because there are some bots building the test-suite with -O0, to unblock them. The proper fix (run in lightweight lowering in the backend) will need a bit more time unfortunately.
> 
> 
> Cheers.
> And I will commit the test of this patch then as that still seems useful to me.
> 


Sounds good to me, thanks!


More information about the llvm-commits mailing list