[PATCH] D83520: [llvm-libtool-darwin] Allow flattening archives

Sameer Arora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 07:14:01 PDT 2020


sameerarora101 marked 3 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-libtool-darwin/archive-flattening.test:7-8
+## Cannot read archive:
+# RUN: echo '!<arch>' >  %t-invalid-archive.lib
+# RUN: echo 'invalid' >> %t-invalid-archive.lib
+# RUN: not llvm-libtool-darwin -static -o %t.lib %t-invalid-archive.lib 2>&1 | \
----------------
jhenderson wrote:
> It's not committed at the time of writing, but D83834 adds a utility to split an input file into smaller pieces. It might be an even nicer way than using echo to emit the archive.
Ok, I can wait for it (while I also need to wait for few others to review this diff) Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83520/new/

https://reviews.llvm.org/D83520





More information about the llvm-commits mailing list