[PATCH] D83520: [llvm-libtool-darwin] Allow flattening archives

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the test case reordering. If you want to wait for D83834 <https://reviews.llvm.org/D83834> too, then that's fine by me.



================
Comment at: llvm/test/tools/llvm-libtool-darwin/archive-flattening.test:6
+
+## Cannot read archive:
+# RUN: echo '!<arch>' >  %t-invalid-archive.lib
----------------
I'd reverse the order - put the positive cases before the negative ones.


================
Comment at: llvm/test/tools/llvm-libtool-darwin/archive-flattening.test:7-8
+## Cannot read archive:
+# RUN: echo '!<arch>' >  %t-invalid-archive.lib
+# RUN: echo 'invalid' >> %t-invalid-archive.lib
+# RUN: not llvm-libtool-darwin -static -o %t.lib %t-invalid-archive.lib 2>&1 | \
----------------
It's not committed at the time of writing, but D83834 adds a utility to split an input file into smaller pieces. It might be an even nicer way than using echo to emit the archive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83520/new/

https://reviews.llvm.org/D83520