[PATCH] D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm on armv6

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 22:12:48 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/armv6-add-sub-imm.ll:1
+; RUN: llc -mtriple=armv6 %s -o - | FileCheck %s --check-prefix=CHECK
+
----------------
Have you considered removing `armv6-` from the filename? 

If people want to test armv7-, they can simply add another RUN line.

BTW, you may consider `llvm/utils/update_llc_test_checks.py`, which can make test updating easy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83928/new/

https://reviews.llvm.org/D83928





More information about the llvm-commits mailing list