[PATCH] D83837: [LLVM] Fix handling of escaped closing brace `}` in `formatv` (under an option)

Rahul Joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 08:48:07 PDT 2020


jurahul added a comment.

That's a reasonable course of action as well. I could look into fixing all the in-tree uses of formatv() to conform to the strict mode, but I do have concern about out-of-tree uses breaking with this and leading to unnecessary API churn, so for that purpose we would potentially need to keep the legacy mode. So overall, I think updating the documentation seems reasonable. I'll update the review for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83837/new/

https://reviews.llvm.org/D83837





More information about the llvm-commits mailing list