[PATCH] D83837: [LLVM] Fix handling of escaped closing brace `}` in `formatv` (under an option)

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 01:58:09 PDT 2020


sammccall added a comment.

I'm sympathetic to wanting to clean this up, but having two modes without a plan to remove one doesn't seem ideal.

What do you think about adjusting the documentation to describe the actual behaviour instead? It doesn't seem unreasonable - it requires { to be doubled but not }, and there's no ambiguity because } cannot appear inside a replacement sequence therefore must close one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83837/new/

https://reviews.llvm.org/D83837





More information about the llvm-commits mailing list