[PATCH] D83853: [DWARFYAML] Implement the .debug_str_offsets section.

Wed Jul 15 03:01:45 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-str-offsets.yaml:124-132
+# RUN: llvm-readelf -S %t4.o | FileCheck %s --check-prefix=EMIT-SHDR
+
+#      EMIT-SHDR: There are 4 section headers, starting at offset 0x68:
+#      EMIT-SHDR: Section Headers:
+# EMIT-SHDR-NEXT: [Nr] Name               Type     Address          Off    Size   ES Flg Lk Inf Al
+# EMIT-SHDR-NEXT: [ 0]                    NULL     0000000000000000 000000 000000 00      0   0  0
+# EMIT-SHDR-NEXT: [ 1] .debug_str_offsets PROGBITS 0000000000000000 000040 000000 00      0   0  1
----------------
I don't think you need to check the whole section header table in this case. Probably sufficient is just checking the .debug_str_offsets line. It might make more sense to use llvm-readobj style in that case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83853/new/

https://reviews.llvm.org/D83853