[PATCH] D83853: [DWARFYAML] Implement the .debug_str_offsets section.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 02:08:46 PDT 2020


Higuoxing added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-str-offsets.yaml:121
+
+## e) Test that the .debug_str_offsets section is omitted if the "debug_str_offsets" is empty.
+
----------------
jhenderson wrote:
> Hmmm... I would expect the section header to be emitted, but for the section to be empty in this context.
Oh, I misunderstood it. We can wrap `std::vector<StringOffsetsTable>` with an additional `Optional` layer (`Optional<std::vector<StringOffsetsTable>>`). We can add it for other DWARF sections as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83853/new/

https://reviews.llvm.org/D83853





More information about the llvm-commits mailing list