[PATCH] D83699: [Bitcode] Drop invalid branch_weight in BitcodeReader

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 14:10:41 PDT 2020


aprantl added a comment.

So this is a bitcode "upgrade" of sorts. An alternative would be to implement this in Verifier and strip invalid metadata similar to how invalid debug info is stripped, but treating this as an upgrade in the bitcode reader is probably fine too.



================
Comment at: llvm/test/Bitcode/branch-weight.ll:14
+; CHECK-NOT: !prof
+; CHECK-NOT: !"branch_weights"
----------------
Can you add one positive CHECK, too, to make sure this doesn't just print nothing at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83699/new/

https://reviews.llvm.org/D83699





More information about the llvm-commits mailing list