[PATCH] D82817: [llvm] Native size estimator for training -Oz inliner

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

I have some concerns about TensorFlow types and datastructure being directly exposed to Analysis, and relying on macros to conditionally compile all this away.
This seems to me like an indication of a missing layering, and some dependencies to cut through injection somehow.

Can you explain what in InlineSizeEstimatorAnalysis.cpp depends on TF for example? That would be a good starting point to help me understand how to break this dependency.

Thanks!



================
Comment at: llvm/unittests/Analysis/InlineSizeEstimatorAnalysisTest.cpp:101
+#endif
+}
----------------
This is not the kind of test that is implemented as C++ unit-tests in LLVM usually I believe, can you make this a lit/FileCheck test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82817/new/

https://reviews.llvm.org/D82817