[PATCH] D82817: [llvm] Native size estimator for training -Oz inliner

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

In D82817#2148518 <https://reviews.llvm.org/D82817#2148518>, @mtrofin wrote:

> Tried repro-ing this on a macosx.
>
> cmake -GNinja -DLLVM_ENABLE_MODULES=On -DCMAKE_BUILD_TYPE=Release ../llvm
>
> ninja opt
>
> I got a warning - missing submodule 'LLVM_Analysis.InlineSizeEstimatorAnalysis' - but no error.
>
> Could you please point me to the specific bot, I'm probably missing something else in the cmake config - thanks!
>
> In D82817#2148323 <https://reviews.llvm.org/D82817#2148323>, @davide wrote:
>
> > This broke the modules build.
> >
> >   In file included from <module-includes>:109:
> >   /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/Analysis/Utils/TFUtils.h:12:10: fatal error: 'tensorflow/c/c_api.h' file not found
> >   #include "tensorflow/c/c_api.h"
> >            ^~~~~~~~~~~~~~~~~~~~~~
> >   While building module 'LLVM_Backend' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/CodeGen/BranchFolding.h:14:
> >   In file included from <module-includes>:3:
> >   In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/AntiDepBreaker.h:20:
> >   In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/ScheduleDAG.h:24:
> >   In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/TargetLowering.h:34:
> >   In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:32:
> >   /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/MachineFunction.h:27:10: fatal error: could not build module 'LLVM_Analysis'
> >   #include "llvm/Analysis/EHPersonalities.h"
> >    ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> >
> > To reproduce, pass `-DLLVM_ENABLE_MODULES=On`. Please let me know if you need anything else to repro.
> >
> > In the meanwhile, reverted this in:
> >
> >   commit 9908a3b9f521c954cbf6adcec35b14b2f6c8da49 (HEAD -> master, origin/master, origin/HEAD)
> >   Author: Davide Italiano <ditaliano at apple.com>
> >   Date:   Mon Jul 13 12:59:16 2020 -0700
> >  
> >       Revert "[llvm] Native size estimator for training -Oz inliner"
> >      
> >       This reverts commit 83080a294ad7d145d758821bcf4354ad0cb7d299 as
> >       it breaks the macOS modules build.
> >  
> >
>


sure, this is the log:
 http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22740/console


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82817/new/

https://reviews.llvm.org/D82817