[PATCH] D83766: [yaml2obj] - Rename FileHeader::SH* fields.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 06:12:40 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFYAML.cpp:872-873
+         (!FileHdr.EPhOff && !FileHdr.EPhEntSize && !FileHdr.EPhNum &&
+          !FileHdr.EShEntSize && !FileHdr.EShOff && !FileHdr.EShNum &&
+          !FileHdr.EShStrNdx));
   IO.mapOptional("EPhOff", FileHdr.EPhOff);
----------------
jhenderson wrote:
> This assert extension might better belong in a separate patch, to avoid confusing issues.
OK, I'll remove.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83766/new/

https://reviews.llvm.org/D83766





More information about the llvm-commits mailing list