[PATCH] D83766: [yaml2obj] - Rename FileHeader::SH* fields.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 06:10:40 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with request.



================
Comment at: llvm/lib/ObjectYAML/ELFYAML.cpp:872-873
+         (!FileHdr.EPhOff && !FileHdr.EPhEntSize && !FileHdr.EPhNum &&
+          !FileHdr.EShEntSize && !FileHdr.EShOff && !FileHdr.EShNum &&
+          !FileHdr.EShStrNdx));
   IO.mapOptional("EPhOff", FileHdr.EPhOff);
----------------
This assert extension might better belong in a separate patch, to avoid confusing issues.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83766/new/

https://reviews.llvm.org/D83766





More information about the llvm-commits mailing list