[PATCH] D83625: [TSan] Optimize handling of racy address

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 05:19:37 PDT 2020


dvyukov added inline comments.


================
Comment at: compiler-rt/lib/tsan/rtl/tsan_rtl_report.cpp:458
+  Lock lock(&ctx->racy_mtx);
+  for (uptr i = 0; i < ctx->racy_stacks.Size(); i++) {
+    if (hash == ctx->racy_stacks[i]) {
----------------
Please add a helper function for this check b/c it's now duplicated twice.
The same for the address check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83625/new/

https://reviews.llvm.org/D83625





More information about the llvm-commits mailing list