[PATCH] D83625: [TSan] Optimize handling of racy address

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

Hi Joachim,

I think this is useful.
As far a I see this changes behavior a bit. Previously if we match existing racy addrs, we still memorize racy stacks. So reports can be suppressed transitively: second report matches addr, but different stacks; then third report matches stacks with the second one, but a new address; and so on. Now we will match address and bail out.
But I think it's OK. I don't remember now why that transitive behavior was important, and if it was at all or not.

Now looking at the code I am confused about AddRacyStacks. Shouldn't we have both address and stacks already memorized at that point?  Maybe we should remove it while we are here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83625/new/

https://reviews.llvm.org/D83625