[PATCH] D83686: [NFCI] LoopSink pass requires PGO, so rename it as PGOLoopSink

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri created this revision.
lebedev.ri added reviewers: reames, fhahn, mkazantsev, Carrot, mgrang, rnk, danielcdh.
lebedev.ri added a project: LLVM.
Herald added subscribers: nikic, kerbowa, asbirlea, dexonsmith, steven_wu, hiraditya, mgorny, nhaehnle, jvesely.

The `LoopSink` pass doesn't actually do anything unless there's PGO profile info.
I'm interested in looking in adding an early, pre-`LoopRotate` aggressive `LoopSink` pass,
because i believe that will at the very least help to address several of vectorization failures i have analyzed.
But for that, i'll need to somehow convince `LoopSink` to skip profitability checks,
which results in half of the pass being conditional.

So instead, let's unsquat `LoopSink` pass, rename it as `PGOLoopSink`,
which makes room for an actual`LoopSink` pass.

NFCI.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83686

Files:
  llvm/include/llvm/InitializePasses.h
  llvm/include/llvm/LinkAllPasses.h
  llvm/include/llvm/Transforms/Scalar.h
  llvm/include/llvm/Transforms/Scalar/LoopSink.h
  llvm/include/llvm/Transforms/Scalar/PGOLoopSink.h
  llvm/lib/Analysis/LoopPass.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
  llvm/lib/Transforms/Scalar/CMakeLists.txt
  llvm/lib/Transforms/Scalar/LoopSink.cpp
  llvm/lib/Transforms/Scalar/PGOLoopSink.cpp
  llvm/lib/Transforms/Scalar/Scalar.cpp
  llvm/test/CodeGen/AMDGPU/opt-pipeline.ll
  llvm/test/Other/new-pm-defaults.ll
  llvm/test/Other/new-pm-thinlto-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
  llvm/test/Other/opt-O2-pipeline.ll
  llvm/test/Other/opt-O3-pipeline.ll
  llvm/test/Other/opt-Os-pipeline.ll
  llvm/test/Other/pass-pipelines.ll
  llvm/test/Other/pr32085.ll
  llvm/test/Transforms/LICM/loopsink-pr38462.ll
  llvm/test/Transforms/LICM/loopsink-pr39570.ll
  llvm/test/Transforms/LICM/loopsink-pr39695.ll
  llvm/test/Transforms/LICM/loopsink.ll
  llvm/test/Transforms/LICM/pgoloopsink-pr38462.ll
  llvm/test/Transforms/LICM/pgoloopsink-pr39570.ll
  llvm/test/Transforms/LICM/pgoloopsink-pr39695.ll
  llvm/test/Transforms/LICM/pgoloopsink.ll
  llvm/test/Transforms/LICM/sink.ll
  llvm/test/Transforms/Util/PR37334-break-crit-edges-require-dt.ll
  llvm/utils/gn/secondary/llvm/lib/Transforms/Scalar/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83686.277454.patch
Type: text/x-patch
Size: 23690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200713/5c12bdc0/attachment.bin>